Well... the drop in coverage is interesting. I have no idea what went wrong 😅

I think coverage decreased is fine as far as the the test still works.

My guess for the decreased coverage is that coveralls only considered the lines covered by the first run using SQLite3. Runs for MySQLi and Postgres were not considered anymore. Is it even possible to consolidate the runs?

Thanks, I'm testing this right now - will see :)

Oh.. .and about consolidation run... I have no idea - I don't see such an option anywhere.

I think we need to set up COVERALLS_PARALLEL: true for multiple runs. Then setup another job for coveralls_finish.

https://github.com/twinh/php-coveralls#github-actions

@paulbalandan Oh... it was there and I missed it - thanks :)

The new DB Config content looks good! Probably need to rebase.

Great, I broke something and I didn't even notice it. Will try to fix it.

The badge build in readme.md need to be updated to github action badge

Could we name the workflow "PHPUnit" to be consistent with our other test workflows?

I'm all for doing this. Travis has become really slow, whereas Actions seems to be much faster, and having everything in one place is great.

Is there a way to do an "allowed failure" and test against 8 yet with Actions? I know it will fail currently, but it's something we need to get in place sometime soon.

@lonnieezell There's a lot of noise about "allowed failures" but basically it looks like there is not currently an equivalent feature to the way Travis lets us test against nightlies. Check out this issue if you want to contribute to said noise: actions/runner#2347

For now, since the plan is to release 4.1 alongside the PHP changes maybe we should add PHP 8 to the matrix for 4.* branches?

@MGatner That's too bad. The continue on failure action doesn't seem to help here, either, I don't think. Oh well.

But yes, I think adding 8 to 4.1 would be good.

Oooo the experimental flag is a nice find! I'm excited to see how this turns out - I might be adding it to my modules to start getting them ready for PHP 8.

Well... idk if this will work out as we want it to but fingers crossed.
I'm still working with continue-on-error here.

Ok... this is not working. I guess we would have to make all checks successful 😕 Probably it's possible but have no much sense.

Ok, this is a bit redundant but I have no other ideas on how to handle this. Right now PHP 8.0 has its own job which is only run for 4.1 branch.

Too bad that matrix is not available for the if condition on the "main" level. It would simplify our file a lot.

If someone has any other ideas on how to handle this, I'm all ears. Hopefully, github will introduce something similar to allow-failure soon.

Thanks for your work on this! Your experience is very valuable for the big upcoming November stuff.

I think for now I'd rather see a different YML file pushed to the 4.1 branch and develop not deal with 8 at all. IMO 8 is not worth testing right now in any definitive way, and maybe GitHub will have some better solution available by November. 🤞

Yeah... I'm totally fine with excluding PHP8. We can address this later in 4.1 branch.